P14-02: Record second independent review PASS on 8917c19
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
8917c190cf
commit
ad2ea79c7d
@@ -1,8 +1,8 @@
|
||||
{
|
||||
"unit": "P14-02",
|
||||
"title": "ワープの通常接続",
|
||||
"candidate": "728e5e6",
|
||||
"decision": "A07",
|
||||
"candidate": "8917c19",
|
||||
"decision": "A07+A08",
|
||||
"status": "independent_review_pass_awaiting_owner_approval",
|
||||
"acceptance": "途中保存、マナ不足、到着不能時に移動や費用が二重反映されない。",
|
||||
"closed_gaps": {
|
||||
@@ -11,7 +11,8 @@
|
||||
"費用確定規約と二重計上拒否": "移動確定と同じtickで1人3マナを1回だけ差し引き、WARP_TRAVELEDを記録。投影失敗時は課金なし。救助ペアは2人分。",
|
||||
"マナ不足/機能停止/到着不能の原状保持": "残量3未満・停電・片側未評価/無電力・到着セル封鎖で経路から除外し、費用・移動なし。",
|
||||
"途中保存・別PID再開で二重反映なし": "課金直後の保存を別PIDで読み、120分継続のマナ・移動履歴・全状態digestが一致。",
|
||||
"通常UI・影響回帰・性能・独立レビュー": "パレット・コード描画、147本中122 PASS(失敗24本は基準と同一)、性能計測(warp-perf-r01.txt)、独立レビューPASS。"
|
||||
"通常UI・影響回帰・性能・独立レビュー": "パレット(25件)・コード描画、147本中122 PASS(失敗24本は基準と同一)、性能計測、独立レビュー2回PASS。",
|
||||
"A08 客用/業務用の分離": "表層mana_warpは客専用(access \"!staff\")、裏層service_warpは従業員専用で同種同士のみ接続。値はA07と同じ。"
|
||||
},
|
||||
"reviews": [
|
||||
{
|
||||
@@ -27,6 +28,19 @@
|
||||
"UIは接続状態・運賃・停止理由を表示しない/パレットからの実建設UI操作試験なし/描画未目視",
|
||||
"4基(6リンク)で1日tickが約74%増。ただし同配置の客用昇降機4基はさらに重く、ワープ固有ではない。リンク数はN(N-1)/2",
|
||||
"15G/日維持費・救助2人課金・通勤ワープ・同一分複数乗客の専用試験なし(コード確認のみ)"
|
||||
],
|
||||
"note": "r1で従業員も表層ワープを使う点を指摘→owner判断A08で分離"
|
||||
},
|
||||
{
|
||||
"round": 2,
|
||||
"candidate": "8917c19",
|
||||
"verdict": "PASS",
|
||||
"blocking": [],
|
||||
"non_blocking": [
|
||||
"path_service.gd:2260-2261 _route_exists_with_overridesが\"!staff\"を旧比較で読み、停電中の客ワープ経路の理由コードがCONNECTOR_UNAVAILABLEでなくGOAL_UNREACHABLEになる(移動・費用に影響なし)",
|
||||
"path_service.gd:2193-2194 _has_permitted_layer_crossingも同様(現ワープは層をまたがないため無害)",
|
||||
"A08以前のaccess \"\"ワープ接続を含むセーブは原子的に読込拒否(配布済みセーブにワープなし)",
|
||||
"描画未目視"
|
||||
]
|
||||
}
|
||||
],
|
||||
@@ -57,21 +71,25 @@
|
||||
"tests/ui/test_cleaning_gameplay.gd"
|
||||
],
|
||||
"source_sha256": {
|
||||
"data/facilities/infrastructure/mana_warp.tres": "91b359dee569c33c98fa34f0b7aa98ca17b3fab4041c4b8ccea5355ef2f5a364",
|
||||
"scripts/transport/warp_service.gd": "a4c093b0cbef28960b8981c75d1bff5bb7e820343af90ea5936564ffe8333ac1",
|
||||
"scripts/world/facility_infrastructure_projector.gd": "e4bd360176070bb90aa40d0a1220d20b0011cd66b5dc5f83df3af9a5703106d0",
|
||||
"scripts/world/path_service.gd": "fcf6586e1b6392b79402f0496e6574396fb8634bc8465a79412382e63506b632",
|
||||
"scripts/data/facility_catalog.gd": "b2563687f82a6bae71fb96abab85070e1da8287df6a3e4dcef0e9c179acfdd56",
|
||||
"autoload/simulation_runtime.gd": "81e2e4a3b137db0bc8e69c7676da31faffc3c80527a8f4f2f846cf4eb9998a17",
|
||||
"scenes/main/main.gd": "c64d7aa6ce5e3a7cc61dfec959f23b6041679364b0f3ccaa6b9267d316d73c23",
|
||||
"scripts/ui/pixel_tower_art.gd": "0e6c329479ec1988778c39a857099ab5ea7c7bfd9f8107761fd5b834a08f7550",
|
||||
"tests/transport/test_runtime_warp.gd": "c8e102478aab67bb2cc4120f7d66464f6a753ae5b388f51da61e21638784017f",
|
||||
"tests/ui/test_main_dashboard.gd": "f89cbd157293c7b2a9b9b2f0ce13ea6ad3199fd0ed832fe29fe0dee325d46305"
|
||||
"data/facilities/infrastructure/mana_warp.tres": "42f1156e04a4454d8525bf3dd77b214a39e11bb7c5e749af1413fe77cdb1e456",
|
||||
"scripts/transport/warp_service.gd": "7602c6b8a9672a703bfa98a1424c2cf68cf50184f87f72349d564af6a5ca9d41",
|
||||
"scripts/world/facility_infrastructure_projector.gd": "7903b7aa6a46b50150beeb13dd8675ce34168c044b1b818f0dc6e2f7e1872d51",
|
||||
"scripts/world/path_service.gd": "fd0f4b202291eda6ab06442d14373f9c2457627550958fa79008d2f828b21521",
|
||||
"scripts/data/facility_catalog.gd": "08a09405a4f07a6b5fd21ba41eff347692f376c50306ccf6ae18e74ed95adacf",
|
||||
"autoload/simulation_runtime.gd": "68d03872a591955740346a894fa4139cea75ed264428d61ade181532ea398b41",
|
||||
"scenes/main/main.gd": "e09c361603da85b7a8b1e299a62b0f9b27f2b20b373b511e6450fe281e16614e",
|
||||
"scripts/ui/pixel_tower_art.gd": "f766b47167db8bd5906b1467fd6f8587af8e9268304c7ba209a9eb157847165e",
|
||||
"tests/transport/test_runtime_warp.gd": "ce263dd680dfa753f7435b85a733e3909740e98ec75e9e3b72750ed11b664f85",
|
||||
"tests/ui/test_main_dashboard.gd": "305227c1077a92ef3ee522b561a68b0685767740b46b51ff789c800931647ef1",
|
||||
"data/facilities/infrastructure/service_warp.tres": "712ae26bf2d9d18c9da6344ee18ef716250e051693bcace586b85f35a794dba2"
|
||||
},
|
||||
"not_claimed": [
|
||||
"Windows実機",
|
||||
"完成素材・描画の目視",
|
||||
"P06-02全体(別単位)",
|
||||
"P14全体"
|
||||
],
|
||||
"followups": [
|
||||
"\"!\"接頭辞accessを_route_exists_with_overridesと_has_permitted_layer_crossingにも適用する"
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user