docs: formally close P24-03 with reviewed integration and final evidence

This commit is contained in:
Takeshi
2026-10-13 09:41:59 +09:00
parent 0a759f13ae
commit b84c3499d1
11 changed files with 263 additions and 30 deletions
@@ -0,0 +1,48 @@
{
"plan_id": "P24-03",
"state": "completed",
"completed_at_jst": "2026-10-13T09:40:31.868894+09:00",
"implementation_commit": "4cefcff849d4dc1211caa5066e24bfae666cc2f4",
"integration_commit": "0a759f13aed03c05fd4a25ab4a2c26eefec94e3c",
"spec_ref": "docs/spec/acceptance/P24-03-code-r02.json",
"spec_sha256": "dbb885b47a3ee4af3d4180bb97fe746e26a0e08d75af2cd3b5b727ed337bd37c",
"all_required_conditions": [
"facility_lifecycle",
"guest_lifecycle",
"staff_lifecycle",
"layer_and_values",
"invalid_and_failed_load",
"normal_os_input",
"final_validation_review"
],
"mandatory_conditions_unmet": 0,
"all_required_evidence_present": true,
"passed_receipts": {
"validation": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/execution/p24-03-formal-closure-r01/validation.json",
"review": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/execution/p24-03-formal-closure-r01/review.json",
"integration": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/execution/p24-03-formal-closure-r01/integration.json",
"final": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/execution/p24-03-formal-closure-r01/final.json"
},
"reused_raw_evidence": "/Users/korizatou114/Projects/TheTree-managed-worktrees/p24-03-code/.runtime/P24-03/build/p24-evidence/index.json",
"existing_full_regression": {
"suites": 173,
"checks": 14810,
"failures": 0,
"not_delivery_count": true
},
"supplemental_positive_metadata": {
"checks": 17,
"failures": 0,
"result": "artifacts/original-completion-2026-10-02/p24-positive-metadata-r02/result.json"
},
"normal_os_input_cross_process": {
"producer_pid": 17306,
"consumer_pid": 19943,
"same_manifest_world": true,
"whole_model_and_screen_values_equal": true
},
"review_guard_bytes": 494833,
"windows_acceptance": false,
"whole_game_completed": false,
"runner_support_not_added_to_original88": true
}
@@ -0,0 +1,14 @@
{
"task_id": "P24-03",
"commit": "0a759f13aed03c05fd4a25ab4a2c26eefec94e3c",
"kind": "final",
"checks": [
{
"id": "p24-acceptance",
"exit_code": 0,
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/c002071e0a5e4a61ace7d5f037941ecd",
"passed": true
}
],
"passed": true
}
@@ -0,0 +1,5 @@
{
"candidate": "0a759f13aed03c05fd4a25ab4a2c26eefec94e3c",
"main_base": "41a5acbd434990f3253f4990a6479b730d2312ee",
"authority": "Existing explicit main-update authorization plus latest explicit human continued-execution directive; no new human SHA utterance claimed"
}
@@ -0,0 +1,14 @@
{
"task_id": "P24-03",
"commit": "0a759f13aed03c05fd4a25ab4a2c26eefec94e3c",
"kind": "integration",
"checks": [
{
"id": "p24-acceptance",
"exit_code": 0,
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/2a8e262ae43c49e0980b41808fc4ac74",
"passed": true
}
],
"passed": true
}
@@ -0,0 +1,27 @@
{
"task_id": "P24-03",
"commit": "4cefcff849d4dc1211caa5066e24bfae666cc2f4",
"status": "pass",
"summary": "全7条件(facility/guest/staff lifecycle、layer_and_values、invalid_and_failed_load、normal_os_input、final_validation_review)の証拠を、提供された差分・ソース・Runner結果と突合し、受入P24-03は満たされていると判断する。critical/high/mediumの指摘はない。変更は allowed_paths 内に収まっている。新suite以外の既存suiteのSHA・marker・cleanupは変更されておらず、試験の削除・無効化もない。製品コードの変更は2点のみで、(1) Main の interface_selection version 判定を数値1(JSON由来の1.0を含む、bool/文字列/非1は拒否)に修正、(2) 客パネルで選択対象が不在のとき OptionButton を未選択(-1)にする、である。実GuestService/StaffServiceの離脱、実建設→実撤去、Unique解雇拒否、履歴(永続recordと離職給与43G)の保持、UI収集がRuntime digestを変えないこと、不正version拒否は新suite(41 checks, 0 failures)で確認されている。全173 roster(import/parse含む)がstrict markerで14810 checks, 0 failuresで通過し、cleanup/guardエラーもなく、実PIDとsource SHAが一致している。正式保存の同一manifest/world SHAに対し、別PID(17306と19943)で通常Mainを再開し、選択ID、レイヤー、施設の地図強調、各画面値が完全一致している。画面値は実ラベル文字列とneed barから独立に解析され、model値と等価であることが確認されている。通常OS入力はCUA native appによる実クリック6件(施設・客・職員・レイヤー選択、保存、再開)で、各stepのPID・画面・source mapが突合されている。生成物は injected=true と faithful_transcription の限界が開示されている。Godot内部のemitや関数呼出しのみの証拠ではない。正式独立レビューは本レビューが担う最終段で、pending_reviewの状態は設計どおり。Windows条件は仕様上別扱いで未受入のまま。以下は低優先度の所見。",
"acceptance_ids": [
"P24-03"
],
"findings": [
{
"severity": "low",
"message": "cross-process の P24_OBSERVATION ログ行はエンジン出力ではなくcollector正規化で生成されている。元エンジンログと元raw報告はハッシュ付きで保持され、その旨も明示されているため受入可能だが、独立計測ではない。"
},
{
"severity": "low",
"message": "JSONで復号された float 1.0 の version を受理する正例(施設・職員・客の復元)は、リポジトリ外の補足プローブ(17 checks)でのみ確認されており、新suite自体は負例のみを持つ。次回の保守では正例を新suiteに取り込むことが望ましい。"
},
{
"severity": "low",
"message": "OS入力traceはCUA tool stepの書き起こし(faithful_transcription)であり、元のtool RPCは独立計測されていない。限界は index に開示済みで、root指示の方針(CUAの実OS配信を許可し、emit/関数呼出しのみは不可)とも整合する。"
},
{
"severity": "low",
"message": "producerの17306は先行する予備ペアのconsumerとして起動したprocessを再利用している。最終ペアは専用の不変package(formal-package-os)に保存・再開しており、証拠上の矛盾はない。"
}
]
}
@@ -0,0 +1,101 @@
{
"contract": {
"id": "P24-03",
"title": "選択と保存の受入",
"requirement_ids": [
"P24-03"
],
"acceptance_ids": [
"P24-03"
],
"spec_ref": "docs/spec/acceptance/P24-03-code-r02.json",
"base_commit": "286730f88ce430a1cbe1501d40361188f832d235",
"worker": "codex",
"allowed_paths": [
"scenes/main/main.gd",
"scripts/ui/guest_observation_panel.gd",
"scripts/ui/staff_management_panel.gd",
"tests/ui/test_selection_departure.gd",
"tests/ui/test_selection_departure.gd.uid",
"tests/ui/fixtures/selection_cross_process.gd",
"tests/ui/fixtures/selection_cross_process.gd.uid",
"tools/check_p24_selection_evidence.py",
"tools/run_all_tests.py",
"tools/regression/suite-policy.json",
"docs/plans/original-completion-2026-10-02/execution/completion_marker_contracts.json",
"docs/plans/original-completion-2026-10-02/execution/p24-03/**"
],
"depends_on": [],
"resource_locks": [
"main-selection-lifecycle",
"selection-acceptance-profile",
"regression-roster-policy"
],
"validation_ids": [
"p24-acceptance"
],
"max_repair_attempts": 2,
"spec_sha256": "dbb885b47a3ee4af3d4180bb97fe746e26a0e08d75af2cd3b5b727ed337bd37c"
},
"implementation_commit": "4cefcff849d4dc1211caa5066e24bfae666cc2f4",
"integration_commit": "0a759f13aed03c05fd4a25ab4a2c26eefec94e3c",
"owner": "ユーザーのmain更新明示許可および最新の不要な停止を解除して作業継続する指示に基づく",
"evidence": [
{
"id": 1,
"task_id": "P24-03",
"kind": "validation",
"commit_sha": "9c711860a82d597a48dab595a49d4f23c5f3c370",
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/a44366e665b843268001a31daf2dd7f3-validation.json",
"passed": 0
},
{
"id": 2,
"task_id": "P24-03",
"kind": "validation",
"commit_sha": "c2b8772e237597930e67f1329d8b61143614a244",
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/61f7f1774bd44fc0bb912fedb195f2e0-validation.json",
"passed": 0
},
{
"id": 3,
"task_id": "P24-03",
"kind": "validation",
"commit_sha": "4cefcff849d4dc1211caa5066e24bfae666cc2f4",
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/3df3f128f0e549e7a610e5c6212337ce-validation.json",
"passed": 1
},
{
"id": 4,
"task_id": "P24-03",
"kind": "review",
"commit_sha": "4cefcff849d4dc1211caa5066e24bfae666cc2f4",
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/a1d33697d68b4f6696397137a7874a9a/result.json",
"passed": 0
},
{
"id": 5,
"task_id": "P24-03",
"kind": "review",
"commit_sha": "4cefcff849d4dc1211caa5066e24bfae666cc2f4",
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/ec59a91c09f342a594aa0ec49854c7cf/result.json",
"passed": 1
},
{
"id": 6,
"task_id": "P24-03",
"kind": "integration",
"commit_sha": "0a759f13aed03c05fd4a25ab4a2c26eefec94e3c",
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/155c4f2b95694e52a4424ae8d3b71c3d-integration.json",
"passed": 1
},
{
"id": 7,
"task_id": "P24-03",
"kind": "final",
"commit_sha": "0a759f13aed03c05fd4a25ab4a2c26eefec94e3c",
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/5605937ac12f4a7091fc49d3d85848e1-final.json",
"passed": 1
}
]
}
@@ -0,0 +1,14 @@
{
"task_id": "P24-03",
"commit": "4cefcff849d4dc1211caa5066e24bfae666cc2f4",
"kind": "validation",
"checks": [
{
"id": "p24-acceptance",
"exit_code": 0,
"artifact": "/Users/korizatou114/Library/Application Support/agent-control/the-tree-p24-03-code/runs/978b599053834e99bd97303b07a4d2cd",
"passed": true
}
],
"passed": true
}