174 lines
15 KiB
JSON
174 lines
15 KiB
JSON
{
|
|
"revision": "r290",
|
|
"review_kind": "bounded independent static repair review",
|
|
"reviewed_at_utc": "2026-10-11T23:00:57.612468+00:00",
|
|
"implementation_supported": true,
|
|
"static_accepted": true,
|
|
"static_candidate_accepted": true,
|
|
"build_allowed": false,
|
|
"execution_allowed": false,
|
|
"blockers": [],
|
|
"accepted_scope": "Static fidelity of the single absent typed-array script guard repair only, reusing authenticated parent r285-r02 static findings. No runtime calibration, host build, ABI/load, local/whole equivalence, performance or adoption acceptance.",
|
|
"findings": [
|
|
"Full mechanical inverse: replacing the new typed guard once restores parent r285-r02 CPP byteexact; header byteexact. Encoder format, count/type validation, allocation, append/pop update, Budget ownership/report/notification and fallback code otherwise unchanged.",
|
|
"Primary exact ed1daf0bf Array::get_typed_script returns its Ref<Script>; primary Ref conversion returns Variant(reference). SDK TypedArray<int64_t> initializes builtin INT, empty class name and Variant() script. These support permitting the absent null OBJECT representation alongside NIL, without claiming the observed r287 failure cause is proven.",
|
|
"Typed arrays still require builtin INT and empty class name. Only NIL or OBJECT converting to nullptr pass; all other Variant types and non-null script objects reject. Object conversion is gated by exact OBJECT type, and SDK declares operator Object*(). Non-null Ref script remains held by the Array during this synchronous validation.",
|
|
"All four calibration cases (untyped empty, nine-boundary untyped, typed empty, nine-boundary typed) remain mandatory for compatible=true; comparisons use actual UtilityFunctions::var_to_bytes. A failed encode short-circuits that case engine call and compatibility remains false. No guessed format is enabled on a mismatch.",
|
|
"Unsupported/custom/mixed/readonly/alias handling and old encoder fallback are unchanged by exact inverse. No cache, lifetime, dispatch or callback change is introduced by the local Variant guard.",
|
|
"Original r287 failed local execution and refusal receipt remain pinned and unaccepted; 4024 checks/112 failures cannot be transferred into new codec acceptance."
|
|
],
|
|
"remaining": [
|
|
"Separate authenticated bridge compile/link preexecution review and actual host build are required.",
|
|
"Actual engine calibration and the complete 4024-check/33-codec-case local comparison remain required, including typed/untyped, readonly, integer boundaries and caller-owned bytes mutation isolation.",
|
|
"Root cause of r287 calibration failure is not established by this static repair.",
|
|
"Whole647, stable gain, 50ms stall budget, P95/D10, final172, normal OS/Windows, production adoption and unit completion remain unaccepted."
|
|
],
|
|
"reviewer_runs": {
|
|
"engine": 0,
|
|
"compiler": 0,
|
|
"tests": 0,
|
|
"validator": 0,
|
|
"author": 0,
|
|
"codec": 0,
|
|
"new_agents": 0
|
|
},
|
|
"evidence_sha256": {
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r285-r02/source/tree_numeric_core.cpp": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r285-r02/source/tree_numeric_core.cpp",
|
|
"bytes": 59396,
|
|
"sha256": "75bc2f659f62889fccac5990461f5b51e8b87f30ca0791e4a4c542d37a7c5236"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r285-r02/source/tree_core.hpp": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r285-r02/source/tree_core.hpp",
|
|
"bytes": 3299,
|
|
"sha256": "be46852fe55aeee4e18996b4d87222662b031fd1b946977c81092f4d0707e480"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r290/source/tree_numeric_core.cpp": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r290/source/tree_numeric_core.cpp",
|
|
"bytes": 59737,
|
|
"sha256": "f2156411713c341cce25f37728731b38dca6151b56dd9e848afa0531008527a0"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r290/source/tree_core.hpp": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r290/source/tree_core.hpp",
|
|
"bytes": 3299,
|
|
"sha256": "be46852fe55aeee4e18996b4d87222662b031fd1b946977c81092f4d0707e480"
|
|
},
|
|
"/private/tmp/thetree-prepare-integer-window-codec-null-script-r290.py": {
|
|
"path": "/private/tmp/thetree-prepare-integer-window-codec-null-script-r290.py",
|
|
"bytes": 2842,
|
|
"sha256": "3225e506a35abc46acb5a7e38a7d80bdce22f3ad31e7a87d3c347bf15c4d0d6c"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-source-r284/marshalls.cpp": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-source-r284/marshalls.cpp",
|
|
"bytes": 55439,
|
|
"sha256": "183c43e46d3e4b73c0fb1fc8018da37faeb88c7414dd928b1fb6ff4f4a91a374"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-source-r284/source.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-source-r284/source.json",
|
|
"bytes": 585,
|
|
"sha256": "cbdfe256f152bc8f0c44b849848a94e3eec1e84d6a55f5da69188a6430a148a9"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-budget-record-candidate-r257-r04/performance_budget.candidate.gd": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-budget-record-candidate-r257-r04/performance_budget.candidate.gd",
|
|
"bytes": 11250,
|
|
"sha256": "1010129d3124c3aec037c840a5766a7cdabe60c654999dfb6f23b224140a73f8"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-progress-integration-actual-independent-review-r282.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-progress-integration-actual-independent-review-r282.json",
|
|
"bytes": 14529,
|
|
"sha256": "40b90fe5086d1bb468f14418657b946fac11615b46cdf66de5f0ccac832a8457"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-local-r287/input.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-local-r287/input.json",
|
|
"bytes": 972003,
|
|
"sha256": "65007d4405143a39492b889218687d9b83ddfd230560b543e3072918a192a0e1"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-local-r287/execution.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-local-r287/execution.json",
|
|
"bytes": 22195,
|
|
"sha256": "aafa8d0b92e65ffc01ff0722f902106b6ad89f8919e751da410e22b7f67abc54"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-local-r287/r257-r04-measurement/report.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-local-r287/r257-r04-measurement/report.json",
|
|
"bytes": 10858,
|
|
"sha256": "22e07864c1f7453c3eb38cb81e5bb189e48c9cbe2f31c507b75ce3c51c8174f5"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-array-source-r289/array.cpp": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-array-source-r289/array.cpp",
|
|
"bytes": 27906,
|
|
"sha256": "ad9ebc6db6a962c817e2dbcee7f9c529dccd042090137e00dcf1a0594696f70b"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-array-source-r289/source.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-array-source-r289/source.json",
|
|
"bytes": 291,
|
|
"sha256": "cd89af6dd2258fe71036edf9f92ce6302d823b68c257405e2a56795726e87834"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r290/input.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-candidate-r290/input.json",
|
|
"bytes": 6030,
|
|
"sha256": "668930b0ed56cda8dfe692323e129575bba29697907727f671778871bd507560"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-static-independent-review-r285-r02.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-static-independent-review-r285-r02.json",
|
|
"bytes": 10950,
|
|
"sha256": "bffbdcb491ba0aa68eeac764228c04418d2ef3834624cb1fcb98db773e8369fd"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-local-actual-independent-review-r287.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-integer-window-codec-local-actual-independent-review-r287.json",
|
|
"bytes": 28577,
|
|
"sha256": "ba871137bb6f4d6c73f34795b76e90fce6b53a2139b647620adf117d44fea0b8"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-array-source-r289/ref_counted.h": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-array-source-r289/ref_counted.h",
|
|
"bytes": 7628,
|
|
"sha256": "05ef9e22f969dd4e93d5682e898b86e0ed646bf6d21a0225de9c7d68193bf074"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-array-source-r289/ref-source.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-integer-window-codec-array-source-r289/ref-source.json",
|
|
"bytes": 306,
|
|
"sha256": "633234e67598321413393912f4b52a51b191df5b4adc944d402b10ddd5cc27eb"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-sdk-lifetime-candidate-r131/sdk/include/godot_cpp/variant/typed_array.hpp": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-sdk-lifetime-candidate-r131/sdk/include/godot_cpp/variant/typed_array.hpp",
|
|
"bytes": 6553,
|
|
"sha256": "e501619ecd1489869c119c87b6738d6999f9b328bba86b5577023257acce5bbe"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-sdk-lifetime-candidate-r131/sdk/include/godot_cpp/variant/variant.hpp": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/artifacts/original-completion-2026-10-02/p23-02-native-sdk-lifetime-candidate-r131/sdk/include/godot_cpp/variant/variant.hpp",
|
|
"bytes": 12723,
|
|
"sha256": "323e24a2ef20c5e9a9ab13fb432e8c2aaceeef6907e6c51c80883642354228e3"
|
|
}
|
|
},
|
|
"canonical_doc4_context_pins": {
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/IMPLEMENTATION_PLAN.md": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/IMPLEMENTATION_PLAN.md",
|
|
"bytes": 492762,
|
|
"sha256": "c2f4824ac3f47231395820ef792d88884a6d7c578f9f6c7b1379619c25fe7a01"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/PROGRESS_INTEGRATION.md": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/PROGRESS_INTEGRATION.md",
|
|
"bytes": 410826,
|
|
"sha256": "9eaf70befb9b94d0b890caef1d8afd8f6348a3b6621fd03d5fd469f9638806c0"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/work_packages.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/work_packages.json",
|
|
"bytes": 1180547,
|
|
"sha256": "f6538388b31fecba52276fe90dca327afc00a54ea530a8b4ecddfc87fd32ae7e"
|
|
},
|
|
"/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/progress_snapshot.json": {
|
|
"path": "/Users/korizatou114/Projects/とりにく工房ゲーム制作部/docs/plans/original-completion-2026-10-02/progress_snapshot.json",
|
|
"bytes": 529159,
|
|
"sha256": "9a03b385c8e53570012a0e3b977a8c78a3cec11ea8d5f585841f5abff3c19517"
|
|
}
|
|
},
|
|
"pin_counts": {
|
|
"direct": 21,
|
|
"current_doc4": 4,
|
|
"total": 25
|
|
},
|
|
"canonical_context": "r282 unchanged; HEAD checkpoint addition does not alter these four document bytes",
|
|
"original_17_acceptance_changed": false,
|
|
"adoption_accepted": false,
|
|
"performance_accepted": false
|
|
}
|